Exclude hidden-column scores from leaderboard and submission APIs - #2526
Open
ihsaan-ullah wants to merge 2 commits into
Open
ihsaan-ullah wants to merge 2 commits into
ihsaan-ullah wants to merge 2 commits into
Conversation
IdirLISN
approved these changes
Sep 2, 2026
IdirLISN
approved these changes
Sep 15, 2026
Didayolo
force-pushed
the
hidden-column-scores
branch
from
September 15, 2026 13:51
71c9b9e to
4e17fe3
Compare
Member
=========================== short test summary info ============================
FAILED src/apps/api/tests/test_submissions.py::HiddenColumnSubmissionScoreTests::test_anonymous_user_does_not_see_hidden_column_score_in_submission_detail - assert 404 == 200
FAILED src/apps/api/tests/test_submissions.py::HiddenColumnSubmissionScoreTests::test_anonymous_user_does_not_see_hidden_column_score_in_submission_list - assert 0 == 1
===== 2 failed, 266 passed, 2 skipped, 2349 warnings in 360.90s (0:06:00) ======Those two tests assume anonymous users can read finished leaderboard submissions, which #2536 (already on develop) removed. Anonymous denial is now covered by the tests at |
Scores for columns organizers mark as hidden were still visible to anyone viewing a leaderboard or submission, even though they were correctly hidden from the leaderboard table itself. Hidden scores are now excluded everywhere, for every type of user. Added tests to cover this going forward.
Didayolo
force-pushed
the
hidden-column-scores
branch
from
September 15, 2026 14:26
4e17fe3 to
603b6c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scores for columns organizers mark as hidden were still visible to anyone viewing a leaderboard or submission, even though they were correctly hidden from the leaderboard table itself. Hidden scores are now excluded everywhere, for every type of user. Added tests to cover this going forward.
Issues this PR resolves
A checklist for hand testing
Checklist